[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config
Thomas Monjalon
thomas.monjalon at 6wind.com
Fri Jul 22 10:21:34 CEST 2016
2016-07-21 09:35, Wang, Xiao W:
> From: Chen, Jing D
> > > --- a/drivers/net/fm10k/fm10k_ethdev.c
> > > +++ b/drivers/net/fm10k/fm10k_ethdev.c
> > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,
> > >
> > > PMD_INIT_FUNC_TRACE();
> > >
> > > - if (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> > > - FM10K_RSSRK_ENTRIES_PER_REG)
> > > + if (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> > > + FM10K_RSSRK_ENTRIES_PER_REG))
> > > return -EINVAL;
> > >
> > > if (hf == 0)
> >
> > It's also possible that app wants to update rss key and not expect to update hash
> > function.
> > Is that indicate we shouldn't return error in case hf == 0?
> >
>
> If the app just wants to update RSS key, it needs to read out the RSS config first, then
> change only the key field. This is what testpmd does for this operation.
>
> hf == 0 will disable RSS feature, I think we should return error to protect multi-queue.
Jing, do you confirm we can apply this patch, please?
More information about the dev
mailing list