[dpdk-dev] [PATCH] scripts: check commits with checkpatch
Thomas Monjalon
thomas.monjalon at 6wind.com
Tue Jun 7 09:43:58 CEST 2016
2016-06-02 13:33, Bruce Richardson:
> On Thu, Jun 02, 2016 at 11:13:15AM +0200, Thomas Monjalon wrote:
> > The new option -n allows to give a number of commits to check
> > from the git HEAD.
> > If neither -n nor patch files are given, the commits after
> > origin/master are checked.
> >
>
> Yep, I love it, exactly what I wanted to replace my own checkpatch script wrapper!
>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
>
> Testing this out here, I find that git format-patch includes the diff stats
> in the output, which then can trigger long-line warnings for the commit message.
>
> WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #8:
> examples/my-new-test-app/basicfwd.c | 342 +++++++++++++++++++++++++++++++++++++
>
> To fix this, I suggest replacing "format-patch --stdout" with "show --format=email"
> since that should give the same output just without the change stats.
>
> With this one adjustment:
>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Applied with --no-stat adjustment.
More information about the dev
mailing list