[dpdk-dev] [PATCHv6 0/7] Implement pmd hardware support exports

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Jun 7 14:27:46 CEST 2016


2016-06-07 08:08, Neil Horman:
> On Tue, Jun 07, 2016 at 11:34:56AM +0200, Thomas Monjalon wrote:
> > Hi Neil,
> > 
> > You are creating a new directory buildtools/ which depends on mk/
> I don't know what this means.  Every part of the dpdk that builds code depends
> on the infrastructure in mk/ (save for the scripts below)

Yes, I'm just doing a summary of the build system.

> > We also have some scripts used in the build process:
> > 	scripts/auto-config-h.sh
> > 	scripts/depdirs-rule.sh
> > 	scripts/gen-build-mk.sh
> > 	scripts/gen-config-h.sh
> > 	scripts/relpath.sh
> > I think we should move these scripts somewhere else, probably in mk.
> > So we would have only 2 directories for the build system and we would
> > keep the scripts directory only for dev tools.
> > 
> > If we want to make a step further, we can rename scripts/ to devtools/
> > and tools/ to usertools/.
> > 
> > Opinions?
> > 
> I suppose if you like, sure, though I would caution against moving them to mk/
> as no one really expects executable scripts in the infrastructure makefile area.
> If you want to move the buildtool scripts elsewhere I would suggest
> buildtools/scripts.

Yes that's what I thought first, but as stated above, buildtools depends on mk,
and mk/ depends on these scripts.

> Either way though, this movement seems to fall outside of the purview of the
> purpose of the changeset associated with this email thread.

Yes, just discussing for possible more changes.


More information about the dev mailing list