[dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator

Azarewicz, PiotrX T piotrx.t.azarewicz at intel.com
Wed Jun 8 09:46:33 CEST 2016


> 2016-05-25 15:34, Piotr Azarewicz:
> > This patch improve generate_random_key() function by replacing rand()
> > function with reading from /dev/urandom.
> >
> > CID 120136 : Calling risky function (DC.WEAK_CRYPTO)
> > dont_call: rand should not be used for security related applications,
> > as linear congruential algorithms are too easy to break
> >
> > Coverity issue: 120136
> >
> > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz at intel.com>
> > ---
> >  examples/l2fwd-crypto/main.c |   18 +++++++++++++-----
> 
> Is it relevant for this example?

Maybe not. But it don't break anything, and in the end make Coverity tool happy.

Declan, please share your opinion.


More information about the dev mailing list