[dpdk-dev] [PATCH v4 01/39] bnxt: new driver for Broadcom NetXtreme-C devices
Bruce Richardson
bruce.richardson at intel.com
Wed Jun 8 12:31:30 CEST 2016
On Tue, Jun 07, 2016 at 08:25:44AM +0200, Thomas Monjalon wrote:
> Hi Stephen,
> Reminder from http://dpdk.org/dev#send:
>
> git send-email -39 -v4 --cover-letter --annotate
> --in-reply-to <Message-ID of the previous patch>
>
> Please do not forget --in-reply-to. Thanks
Three other minor style updates as well that would make my life a little easier:
* The sign-off type tags at the bottom of the email are kept in logical
chronological order (irrespective of actual chronological order). This means
that all signed-off-by tags go together followed by a reviewed-by tag afterwards.
* Watch out for initial caps at the start of a commit title. [This will be caught
by the check-git-log.sh script if you want to run that]
* The history updates from vN to vN+1 are best put after the signoffs and prefixed
with a cutline, so that they get stripped automatically when the patch is applied.
Otherwise I have to delete them manually from the commit message. The format of
the messages is therefore best done as:
bnxt: <title>
<commit message>
Signed-off-by: <author1>
Signed-off-by: <author2>
Reviewed-by: <reviewer1>
---
vN changes
<description of changes>
Thanks,
/Bruce
More information about the dev
mailing list