[dpdk-dev] [PATCH v1 1/1] examples/quota_watermark: fix low_watermark variable placement

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Jun 8 22:36:21 CEST 2016


2016-05-23 14:19, Piotr Azarewicz:
> qw app at its init stage reserve 2*sizeof(int) memory space for quota
> and low_watermark shared variables, but both apps (qw and qwctl) assign
> wrong address for low_watermark pointer (out of reserved memzone space)
> due to wrong pointer arithmetic.
> 
> CID 30709 : Extra sizeof expression (SIZEOF_MISMATCH)
> suspicious_pointer_arithmetic: Adding 4UL /* sizeof (int) */ to pointer
> (unsigned int *)(*qw_memzone).addr of type unsigned int * is suspicious
> because adding an integral value to this pointer automatically scales
> that value by the size, 4 bytes, of the pointed-to type, unsigned int.
> Most likely, sizeof (int) is extraneous and should be replaced with 1.
> 
> Coverity issue: 30709
> Fixes: 1d6c3ee3321a ("examples/quota_watermark: initial import")
> 
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz at intel.com>

Applied, thanks

Is this example really useful?


More information about the dev mailing list