[dpdk-dev] [PATCH 2/3] librte_eal: Import FreeBSD sys/tree.h into librte_eal/common

Stephen Hemminger stephen at networkplumber.org
Thu Jun 9 02:58:48 CEST 2016


On Thu,  9 Jun 2016 02:53:53 +0200
Nikita Kozlov <nikita at elyzion.net> wrote:

> This structure is used inside the rte_lpm6 lib for storing added rules.
> It's imported from FreeBSD-10.3 from /usr/include/sys/tree.h, another
> solution could have been to use on Linux the version from libbsd but it
> would create an external dependency.
> 
> Signed-off-by: Nikita Kozlov <nikita at gandi.net>

Using Red-black tree is a good idea, and we have been doing it for a while
both on v4 and v6.

But this is not the way to handle it.
Please don't copy a header file which is available already on both BSD and Linux.




More information about the dev mailing list