[dpdk-dev] [PATCH v3 08/20] vhost: introduce new API to export numa node

Yuanhan Liu yuanhan.liu at linux.intel.com
Thu Jun 9 06:45:00 CEST 2016


On Wed, Jun 08, 2016 at 02:51:33PM -0700, Rich Lane wrote:
> On Mon, Jun 6, 2016 at 8:51 PM, Yuanhan Liu <yuanhan.liu at linux.intel.com>
> wrote:
> 
>     @@ -248,14 +248,9 @@ new_device(struct virtio_net *dev)
>             internal = eth_dev->data->dev_private;
> 
>      #ifdef RTE_LIBRTE_VHOST_NUMA
>     -       ret  = get_mempolicy(&newnode, NULL, 0, dev,
>     -                       MPOL_F_NODE | MPOL_F_ADDR);
>     -       if (ret < 0) {
>     -               RTE_LOG(ERR, PMD, "Unknown numa node\n");
>     -               return -1;
>     -       }
>     -
>     -       eth_dev->data->numa_node = newnode;
>     +       newnode = rte_vhost_get_numa_node(dev->vid);
>     +       if (newnode > 0)
> 
> 
> Should be "newnode >= 0". 

Nice catch! Thanks.

	--yliu


More information about the dev mailing list