[dpdk-dev] [PATCH v3 07/13] enic: use Tx completion messages instead of descriptors

Bruce Richardson bruce.richardson at intel.com
Fri Jun 10 23:18:14 CEST 2016


On Thu, Jun 02, 2016 at 05:22:51PM -0700, John Daley wrote:
> The NIC can either DMA a separate completion message for each
> completed send or periodically just DMA an index of the last
> completed send. Switch to the second method which improves
> cache locality and performance.
> 
> Signed-off-by: John Daley <johndale at cisco.com>

Can you perhaps send me an updated wording for this commit message as the title
and commit message conflict. The title says to use completion messages not
descriptors, while the body talks about moving away from a completion message
way of working.
Is the former method a descriptor writeback method, while the latter a head
pointer writeback? If so, I think the title could be:

"enic: use Tx head pointer not descriptor writeback"

or something similar.

Again, if you send on the updated commit text, I'll just update it on apply. I'd
ideally like to get this patchset pushed to next-net first thing Monday.

/Bruce



More information about the dev mailing list