[dpdk-dev] [PATCH v3 18/20] thunderx/config: set max numa node to two

[Jerin Jacob]

On Wed, Jun 08, 2016 at 06:54:43PM +0100, Ferruh Yigit wrote:
> On 6/7/2016 5:40 PM, Jerin Jacob wrote:
> > Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> > ---
> >  config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
> > index 7940bbd..cc12cee 100644
> > --- a/config/defconfig_arm64-thunderx-linuxapp-gcc
> > +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
> > @@ -34,6 +34,7 @@
> >  CONFIG_RTE_MACHINE="thunderx"
> >  
> >  CONFIG_RTE_CACHE_LINE_SIZE=128
> > +CONFIG_RTE_MAX_NUMA_NODES=2
> Isn't this platform level configuration? And sets max numa nodes
> independent from driver, right?
> 

Yes

> Can you please add some more information why this is required?
> 
> Also does it make sense to separate this patch from driver patchset?

Yes, I will separate this patch from the series.

Thanks Ferruh for the comprehensive review of this patch series.
I will send the v4, addressing all of your review comments.

Jerin

> 
> >  
> >  #
> >  # Compile Cavium Thunderx NICVF PMD driver
> > 
>