[dpdk-dev] [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display
Iremonger, Bernard
bernard.iremonger at intel.com
Mon Jun 13 18:07:56 CEST 2016
Hi Pablo,
<snip>
> > Subject: [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from
> > fwd_config_display
> >
> > Remove fwd_config_setup from fwd_config_display and check that
> > forwarding has been setup before displaying forwarding configuration.
> > Add call to fwd_config_setup for corelist, coremask, nbcore setup.
> > Add call to fwd_config_setup for portlist, portmask, nbport setup.
>
> Probably we need to add that call to the commands that change number of
> RX/TX queues, as well.
I will check this.
> > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
> > ---
> > app/test-pmd/cmdline.c | 23 ++++++++++++++++-------
> > app/test-pmd/config.c | 6 ++++--
> > 2 files changed, 20 insertions(+), 9 deletions(-)
> >
>
> [...]
>
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -1424,8 +1424,10 @@ pkt_fwd_config_display(struct fwd_config *cfg)
> > void
> > fwd_config_display(void)
> > {
> > - fwd_config_setup();
> > - pkt_fwd_config_display(&cur_fwd_config);
> > + if (cur_fwd_config.nb_fwd_ports)
> > + pkt_fwd_config_display(&cur_fwd_config);
> > + else
> > + printf("Please set portlist first\n");
>
> I think this is not necessary. I would call fwd_config_setup() at startup, so
> everything is setup when this is called (even if it is the first command when
> the prompt comes up).
> I think at the end of init_config() is a good place.
Ok, I will try this.
<snip>
Regards,
Bernard.
More information about the dev
mailing list