[dpdk-dev] [PATCH v4 0/4] app/test: rework crypto AES unit test

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Jun 13 22:26:26 CEST 2016


> Fan Zhang (4):
>   app/test: categorize crypto AES test vectors into new file
>   app/test: add unified crypto aes test
>   app/test: utilize new unified crypto AES test function
>   app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit
>     tests

My first comment on v1 was:
"
The first three patches have no real meaning separately.
As they move and rework some code, it is better to not split
with some patches which add code from nowhere and others which
remove old code.
Please squash.
"

Do you agree I squash the first 3 patches?

Any other reviewer for this big patchset?



More information about the dev mailing list