[dpdk-dev] [PATCH v5 02/38] bnxt: add HWRM init code

[Ferruh Yigit]

On 6/14/2016 11:55 PM, Stephen Hurd wrote:
> From: Ajit Khaparde <ajit.khaparde at broadcom.com>
> 
> Start adding support to use the HWRM API.
> Hardware Resource Manager or HWRM in short, is a set of API provided
> by the firmware running in the ASIC to manage the various resources.
> 
> Initial commit just performs necessary HWRM queries for init, then
> fails as before.
> 
> Now that struct bnxt is non-zero size, we can set dev_private_size
> correctly.
> 
> The used HWRM calls so far:
> bnxt_hwrm_func_qcaps:
> 	This command returns capabilities of a function.
> 
> bnxt_hwrm_ver_get:
> 	This function is called by a driver to determine the HWRM
> 	interface version supported by the HWRM firmware, the
> 	version of HWRM firmware implementation, the name of HWRM
> 	firmware, the versions of other embedded firmwares, and
> 	the names of other embedded firmwares, etc.  Gets the
> 	firmware version and interface specifications.  Returns
> 	an error if the firmware on the device is not supported
> 	by the driver and ensures the response space is large
> 	enough for the largest possible response.
> 
> bnxt_hwrm_queue_qportcfg:
> 	This function is called by a driver to query queue
> 	configuration of a port.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> Reviewed-by: David Christensen <david.christensen at broadcom.com>
> 
> --
> v4:
> Fix few issues highlighted by checkpatch.
> 
> v5:
> Fix footer formatting
> Switch to using the HWRM function descriptions from the source
> documentation
> ---

Hi Stephen,

I run basic checks on the patch set, mainly it compiles and applies
fine, overall patch set looks good.

Only get following checkpatch warning:
Only v5,02/38 has one WARNING:MACRO_WITH_FLOW_CONTROL

And my script caught following typos on commit messages:
v5-07-38: mamagement
v5-12-38: staitstics, asociated
v5-14-38: fo
v5-25-38: cleansup
v5-28-38: arugments
v5-30-38: wraper

If there won't be a new version of patch set, perhaps we can ask Bruce
to fix typos when applying J

Thanks,
ferruh