[dpdk-dev] [PATCH v2] eal: Fix resource leak while secondary process maps pci devices
David Marchand
david.marchand at 6wind.com
Fri Jun 17 14:28:55 CEST 2016
On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa <mukawa at igel.co.jp> wrote:
> This patch fixes resource leak of pci_uio_map_secondary().
> If pci_map_resource() succeeds but mapped address is different from an
> address primary process mapped, this should be error.
> Then the addresses secondary process mapped should be freed.
>
> Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp>
scripts/check-git-log.sh is not happy :
Wrong headline uppercase:
eal: Fix resource leak while secondary process maps pci devices
Wrong headline lowercase:
eal: Fix resource leak while secondary process maps pci devices
Headline too long:
eal: Fix resource leak while secondary process maps pci devices
Missing 'Fixes' tag:
eal: Fix resource leak while secondary process maps pci devices
checkpatch is not happy, but I think we can ignore it.
WARNING:LONG_LINE: line over 80 characters
#48: FILE: lib/librte_eal/common/eal_common_pci_uio.c:93:
+ (size_t)uio_res->maps[j].size);
Anyways, looks good to me, Thomas, can you fix the commit logs of
those last 3 patches on eal ?
Thanks.
--
David Marchand
More information about the dev
mailing list