[dpdk-dev] [PATCH] vhost: fix unchecked return value of fstat

Yuanhan Liu yuanhan.liu at linux.intel.com
Mon Jun 20 09:20:51 CEST 2016


On Wed, Jun 15, 2016 at 01:45:23AM +0800, Huawei Xie wrote:
> Value returned from fstat is not checked for errors before being used.
> Fixes the coverity issue:
> 
> static uint64_t
> get_blk_size(int fd)
> {
> 	struct stat stat;
> 
> 	fstat(fd, &stat);
> 	return (uint64_t)stat.st_blksize;
> >>>  CID 107103 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)
> >>>  check_return: Calling fstat(fd, &stat) without checking return value.
> >>>  This library function may fail and return an error code.
> 
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> 
> Signed-off-by: Huawei Xie <huawei.xie at intel.com>

Acked-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>

Applied to dpdk-next-virtio. Thanks.

	--yliu


More information about the dev mailing list