[dpdk-dev] [PATCH 3/3] vhost: fix potential NULL pointer dereference
Yuanhan Liu
yuanhan.liu at linux.intel.com
Tue Jun 28 05:58:31 CEST 2016
Fix the potential NULL pointer dereference issue raised by Coverity.
578 reconn = malloc(sizeof(*reconn));
>>> CID 127481: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a null pointer "reconn".
579 reconn->un = un;
Coverity issue: 127481
Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
Reported-by: John McNamara <john.mcnamara at intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
---
lib/librte_vhost/vhost_user/vhost-net-user.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c b/lib/librte_vhost/vhost_user/vhost-net-user.c
index 67303a4..a0d83f3 100644
--- a/lib/librte_vhost/vhost_user/vhost-net-user.c
+++ b/lib/librte_vhost/vhost_user/vhost-net-user.c
@@ -577,6 +577,12 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path);
reconn = malloc(sizeof(*reconn));
+ if (reconn == NULL) {
+ RTE_LOG(ERR, VHOST_CONFIG,
+ "failed to allocate memory for reconnect\n");
+ close(fd);
+ return -1;
+ }
reconn->un = un;
reconn->fd = fd;
reconn->vsocket = vsocket;
--
1.9.0
More information about the dev
mailing list