[dpdk-dev] [PATCH v2] virtio: Use cpuflag for vector api

Yuanhan Liu yuanhan.liu at linux.intel.com
Tue Mar 1 06:59:11 CET 2016


On Mon, Feb 29, 2016 at 06:28:10PM +0530, Santosh Shukla wrote:
> Check cpuflag macro before using vectored api.
> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added cpuflag.
> - Also wrap other vectored freind api ie..
> 1) virtqueue_enqueue_recv_refill_simple
> 2) virtio_rxq_vec_setup
> 
> - removed VIRTIO_PMD=n from armv7/v8 config.
> 
> todo:
> 1) Move virtio_recv_pkts_vec() implementation to
>    drivers/virtio/virtio_vec_<arch>.h file.
> 2) Remove use_simple_rxtx flag, so that virtio/virtio_vec_<arch>.h
>    files to provide vectored/non-vectored rx/tx apis.
> 
> Signed-off-by: Santosh Shukla <sshukla at mvista.com>
> ---
> - v2: Removed VIRTIO_PMD=n from arm v7/v8

Firstly, I would not suggest you to send another new version, while there
still was discussions ongoing on old version.

And, you should not mix the ARM stuff here; this patch should only do
what the patch title tells. In generic, don't do two or more things in
one patch.

	--yliu


More information about the dev mailing list