[dpdk-dev] [PATCH v3 2/4] kcp: add kernel control path kernel module
Ferruh Yigit
ferruh.yigit at intel.com
Tue Mar 1 16:53:23 CET 2016
On 3/1/2016 1:02 AM, Stephen Hemminger wrote:
> On Fri, 26 Feb 2016 14:10:39 +0000
> Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>
>> +#define KCP_ERR(args...) printk(KERN_ERR "KCP: " args)
>> +#define KCP_INFO(args...) printk(KERN_INFO "KCP: " args)
>> +
>> +#ifdef RTE_KCP_KO_DEBUG
>> +#define KCP_DBG(args...) printk(KERN_DEBUG "KCP: " args)
>> +#else
>> +#define KCP_DBG(args...)
>> +#endif
>
> These macros will not make netdev developers happy.
>
> Use standard printk macros, and if you want prefix, use pr_fmt
>
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
Hi Stephen,
I removed the macros and send a new version of patch set.
v4:
http://dpdk.org/dev/patchwork/patch/10950/
Thanks,
ferruh
More information about the dev
mailing list