[dpdk-dev] [PATCH v4 2/4] kcp: add kernel control path kernel module

[Stephen Hemminger]

On Tue,  1 Mar 2016 15:41:58 +0000
Ferruh Yigit <ferruh.yigit at intel.com> wrote:

> +
> +static int kcp_net_set_mac(struct net_device *dev, void *p)
> +{
> +	struct sockaddr *addr = p;
> +	int err = 0;

Unnecessary assignment.

> +
> +	if (!is_valid_ether_addr((unsigned char *)(addr->sa_data)))
No cast needed:
	if (!is_valid_ether_addr(addr->sa_data))
		return -EADDRNOTAVAIL;

> +		return -EADDRNOTAVAIL;
> +

Don't you want to validate that dev->addr_len == ETHER_ADDR_LEN?

> +	err = kcp_nl_exec(RTE_KCP_REQ_SET_MAC, dev, addr->sa_data,
> +			dev->addr_len, NULL, 0);
> +	if (err < 0)
> +		return -EADDRNOTAVAIL;
> +
> +	memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
> +
> +	return 0;
> +}
> +