[dpdk-dev] [PATCH v6 1/4] lib/ether: optimize the'rte_eth_tunnel_filter_conf' structure

Sun, Xutao xutao.sun at intel.com
Wed Mar 2 04:10:27 CET 2016


Hi, Panu

> -----Original Message-----
> From: Panu Matilainen [mailto:pmatilai at redhat.com]
> Sent: Tuesday, March 01, 2016 4:54 PM
> To: Sun, Xutao <xutao.sun at intel.com>; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 1/4] lib/ether: optimize
> the'rte_eth_tunnel_filter_conf' structure
> 
> On 03/01/2016 05:47 AM, Xutao Sun wrote:
> > Change the fields of outer_mac and inner_mac from pointer to struct in
> > order to keep the code's readability.
> >
> > Signed-off-by: Xutao Sun <xutao.sun at intel.com>
> > Signed-off-by: Jijiang Liu <jijiang.liu at intel.com>
> > ---
> >   app/test-pmd/cmdline.c                 |  6 ++++--
> >   doc/guides/rel_notes/deprecation.rst   |  5 -----
> >   doc/guides/rel_notes/release_16_04.rst |  2 ++
> >   drivers/net/i40e/i40e_ethdev.c         | 12 ++++++------
> >   lib/librte_ether/rte_eth_ctrl.h        |  4 ++--
> >   5 files changed, 14 insertions(+), 15 deletions(-)
> >
> 
> Since this is the commit actually changing the ABI, its best to actually bump
> LIBABIVER right here as well lest it go forgotten, and also update the list of
> shared library versions in release notes.
> See commit d8c4ae275582784ec0ff3b2c54a4c861b55bc056 for an example.
> 
> Oh and sorry for not noticing this earlier.
> 
> 	- Panu -

I didn't use the Macro "RTE_NEXT_ABI", so I think I don't need to update the shared library verisons.
And I also updated the doc about ABI change in the deprecation.rst and release notes.

Thanks,
Xutao


More information about the dev mailing list