[dpdk-dev] [PATCH 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds

[Simon Kågström]

Hi!

On 2016-03-03 05:08, Stephen Hurd wrote:
> Add additional ETH_LINK_SPEED_* macros for 2, 2.5, 25, and 50 Gbps links
> 
> Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> ---
>  lib/librte_ether/rte_ethdev.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 16da821..cb40bbb 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -254,10 +254,14 @@ struct rte_eth_link {
>  #define ETH_LINK_SPEED_10       10      /**< 10 megabits/second. */
>  #define ETH_LINK_SPEED_100      100     /**< 100 megabits/second. */
>  #define ETH_LINK_SPEED_1000     1000    /**< 1 gigabits/second. */
> +#define ETH_LINK_SPEED_2000     2000    /**< 2 gigabits/second. */
> +#define ETH_LINK_SPEED_2500     2500    /**< 2.5 gigabits/second. */
>  #define ETH_LINK_SPEED_10000    10000   /**< 10 gigabits/second. */
>  #define ETH_LINK_SPEED_10G      10000   /**< alias of 10 gigabits/second. */
>  #define ETH_LINK_SPEED_20G      20000   /**< 20 gigabits/second. */
> +#define ETH_LINK_SPEED_25G      25000	/**< 25 gigabits/second. */
>  #define ETH_LINK_SPEED_40G      40000   /**< 40 gigabits/second. */
> +#define ETH_LINK_SPEED_50G      50000   /**< 50 gigabits/second. */

I realize this is a more general question, but is it really meaningful
to have macros for all possible link speeds? We're working on a PMD
driver with a channelized interface exposed as DPDK ports. Each channel
can be configured with an arbitrary speed, so e.g., 1337 Mbps is also
possible.

To me, it would seem more natural to just have a number in mbits for the
link speed.

// Simon