[dpdk-dev] [PATCH v2 3/7] vhost: refactor virtio_dev_merge_rx

Xie, Huawei huawei.xie at intel.com
Mon Mar 7 07:38:42 CET 2016


On 3/7/2016 2:35 PM, Yuanhan Liu wrote:
> On Mon, Mar 07, 2016 at 06:22:25AM +0000, Xie, Huawei wrote:
>> On 2/18/2016 9:48 PM, Yuanhan Liu wrote:
>>> +	uint16_t idx = vq->avail->ring[avail_idx & (vq->size - 1)];
>>> +	uint32_t vec_id = *vec_idx;
>>> +	uint32_t len    = *allocated;
>>>  
>> There is bug not using volatile to retrieve the avail idx.
> avail_idx? This is actually from "vq->last_used_idx_res". 

uint16_t idx = vq->avail->ring[avail_idx & (vq->size - 1)]

the idx retrieved from avail->ring. 


>
> 	--yliu
>



More information about the dev mailing list