[dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions

Stephen Hemminger stephen at networkplumber.org
Mon Mar 7 17:07:47 CET 2016


On Mon, 07 Mar 2016 12:26:13 +0000
Remy Horton <remy.horton at intel.com> wrote:

> 
> On 04/03/2016 20:34, Stephen Hemminger wrote:
> > On Fri,  4 Mar 2016 15:25:24 +0000
> > Remy Horton <remy.horton at intel.com> wrote:
> >
> >> Implements driver support for setting of MAC address.
> >>
> >> Signed-off-by: Remy Horton <remy.horton at intel.com>
> [..]
> > The version I posted is simpler and reuses existing code paths.
> >
> 
> That version doesn't include a MAC address sanity check - is such a 
> check redundant (or incorrect) in this case?
> 
> ..Remy

That belongs in common code, not in each driver.


More information about the dev mailing list