[dpdk-dev] [PATCH 0/3] ethdev: add helper functions to get eth_dev and dev private data

Ferruh Yigit ferruh.yigit at intel.com
Thu Mar 10 14:37:51 CET 2016


On 3/10/2016 12:00 AM, Thomas Monjalon wrote:
> 2016-02-17 14:20, Ferruh Yigit:
>> This is to provide abstraction and reduce global variable access.
>>
>> Global variable rte_eth_devices kept exported to not break ABI.
>>
>> Bonding driver not selected on purpose, just it seems it is using 
>> rte_eth_devices heavily.
>>
>> There are a few more usage in drivers but they left as it is because they
>> are in fast path code.
> 
> What is the benefit of these functions if you do not plan to remove the
> global variables later?
> 
- Better discipline to abstract, function call can be costly than direct
access, but I believe this is no problem outside of the fast path.
- Helper functions for common tasks, like get private data by port.

> Anyway this discussion targets the release 16.07.
> 
There is no urgency for these.

Thanks,
ferruh


More information about the dev mailing list