[dpdk-dev] [PATCH v2] ixgbe: fix ixgbevf RX/TX function assignment

Bruce Richardson bruce.richardson at intel.com
Thu Mar 10 16:20:06 CET 2016


On Tue, Mar 08, 2016 at 04:49:41PM +0800, Zhe Tao wrote:
> For the secondary process of DPDK to initialize ixgbevf, it will always
> use the simple RX function or LRO RX function, and this behavior is not
> the same RX/TX function selection logic as it is for the primary process,
> so use the ixgbe_set_tx_function and ixgbe_set_rx_function to select the
> RX/TX function when secondary process call the init function for eth dev.  
> 
> Fixes: abf7275bbaa2918 (ixgbe: move to drivers/net/)

That doesn't look to be the commit that actually introduced the bug.

> 
> V2:add fixes line
> 
> Signed-off-by: Zhe Tao <zhe.tao at intel.com>
> 

Checkpatch flags two minor issues with this:
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#33: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1299:
+                       txq = eth_dev->data->tx_queues[eth_dev->data->nb_tx_queues-1];
                                                                                  ^

WARNING:SPLIT_STRING: quoted string split across lines
#38: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1304:
+                       PMD_INIT_LOG(NOTICE, "No TX queues configured yet. "
+                                            "Using default TX function.");

total: 0 errors, 1 warnings, 1 checks, 23 lines checked

/Bruce



More information about the dev mailing list