[dpdk-dev] [PATCH v9 4/5] cryptodev: change burst API to be crypto op oriented

[Trahe, Fiona]

HI Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, March 10, 2016 4:03 PM
> To: Trahe, Fiona
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v9 4/5] cryptodev: change burst API to be crypto
> op oriented
> 
> 2016-03-10 15:41, Fiona Trahe:
> > lib/librte_cryptodev/rte_crypto_sym.h              | 374 ++++++------
> 
> Sorry there is another issue:
> 
> rte_crypto_sym.h:622: warning: argument 'op' of command @param is not
> found in the argument list of __rte_crypto_sym_op_attach_sym_session(struct
> rte_crypto_sym_op *sym_op, struct rte_cryptodev_sym_session *sess)
> rte_crypto_sym.h:628: warning: The following parameters of
> __rte_crypto_sym_op_attach_sym_session(struct rte_crypto_sym_op *sym_op,
> struct rte_cryptodev_sym_session *sess) are not documented:
>   parameter 'sym_op'
> rte_crypto_sym.h:592: warning: unable to resolve reference to
> `rte_cryptodev_session_create' for \ref command
> 
> I've fixed it with the following changes:
> 
>                          * The length of the data pointed to by this field is
>                          * set up for the session in the @ref
>                          * rte_crypto_auth_xform structure as part of the @ref
> -                        * rte_cryptodev_session_create function call.  This
> -                        * length must not exceed 240 bytes.
> +                        * rte_cryptodev_sym_session_create function call.
> +                        * This length must not exceed 240 bytes.
> 
>  /**
>   * Attach a session to a symmetric crypto operation
>   *
> - * @param      op      crypto operation
> + * @param      sym_op  crypto operation
>   * @param      sess    cryptodev session
>   */

This is great fun :)
Do you need me to respin a v10 with that fix?
Or have you applied with the fix?