[dpdk-dev] [PATCH v3] vhost: Fix default value of kickfd and callfd

Yuanhan Liu yuanhan.liu at linux.intel.com
Mon Mar 14 10:12:59 CET 2016


On Mon, Mar 14, 2016 at 05:53:32PM +0900, Tetsuya Mukawa wrote:
> Currently, default values of kickfd and callfd are -1.
> If the values are -1, current code guesses kickfd and callfd haven't
> been initialized yet. Then vhost library will guess the virtqueue isn't
> ready for processing.
> But callfd and kickfd will be set as -1 when "--enable-kvm"
> isn't specified in QEMU command line. It means we cannot treat -1 as
> uninitialized state.
> The patch defines -1 and -2 as VIRTIO_INVALID_EVENTFD and
> VIRTIO_UNINITIALIZED_EVENTFD, and uses VIRTIO_UNINITIALIZED_EVENTFD for
> the default values of kickfd and callfd.

Don't be mean to put an empty line between paragraphs :)

> Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp>

Acked-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>

Thanks.

	--yliu


More information about the dev mailing list