[dpdk-dev] [PATCH] lpm: fix memory leak

Olivier Matz olivier.matz at 6wind.com
Tue Mar 15 13:25:51 CET 2016


Internal lpm structures are not properly freed. Seen with the
lpm6 autotest.

Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
---
 lib/librte_lpm/rte_lpm.c  | 3 +++
 lib/librte_lpm/rte_lpm6.c | 1 +
 2 files changed, 4 insertions(+)

diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c
index dd62f9b..d28e954 100644
--- a/lib/librte_lpm/rte_lpm.c
+++ b/lib/librte_lpm/rte_lpm.c
@@ -318,6 +318,7 @@ rte_lpm_create_v1604(const char *name, int socket_id,
 
 	if (lpm->tbl8 == NULL) {
 		RTE_LOG(ERR, LPM, "LPM memory allocation failed\n");
+		rte_free(lpm->rules_tbl);
 		rte_free(lpm);
 		rte_free(te);
 		goto exit;
@@ -406,6 +407,8 @@ rte_lpm_free_v1604(struct rte_lpm *lpm)
 
 	rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
 
+	rte_free(lpm->tbl8);
+	rte_free(lpm->rules_tbl);
 	rte_free(lpm);
 	rte_free(te);
 }
diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
index 4e9f2d0..faf7684 100644
--- a/lib/librte_lpm/rte_lpm6.c
+++ b/lib/librte_lpm/rte_lpm6.c
@@ -288,6 +288,7 @@ rte_lpm6_free(struct rte_lpm6 *lpm)
 
 	rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
 
+	rte_free(lpm->rules_tbl);
 	rte_free(lpm);
 	rte_free(te);
 }
-- 
2.1.4



More information about the dev mailing list