[dpdk-dev] [PATCH] vhost: remove unnecessary memset for virtio net hdr

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Mar 17 21:52:10 CET 2016


2016-03-17 01:19, Xie, Huawei:
> On 3/16/2016 2:44 PM, Yuanhan Liu wrote:
> > We have to reset the virtio net hdr at virtio_enqueue_offload()
> > before, due to all mbufs share a single virtio_hdr structure:
> >
> > 	struct virtio_net_hdr_mrg_rxbuf virtio_hdr = {{0, }, 0};
> >
> > 	foreach (mbuf) {
> > 		virtio_enqueue_offload(mbuf, &virtio_hdr.hdr);
> >
> > 		copy net hdr and mbuf to desc buf
> > 	}
> >
> > However, after the vhost rxtx refactor, the code looks like:
> >
> > 	copy_mbuf_to_desc(mbuf)
> > 	{
> > 		struct virtio_net_hdr_mrg_rxbuf virtio_hdr = {{0, }, 0}
> >
> > 		virtio_enqueue_offload(mbuf, &virtio_hdr.hdr);
> >
> > 		copy net hdr and mbuf to desc buf
> > 	}
> >
> > 	foreach (mbuf) {
> > 		copy_mbuf_to_desc(mbuf);
> > 	}
> >
> > Therefore, the memset at virtio_enqueue_offload() is not necessary
> > any more; remove it.
> >
> > Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> 
> Acked-by: Huawei Xie <huawei.xie at intel.com>

Applied, thanks


More information about the dev mailing list