[dpdk-dev] [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY
Jan Viktorin
viktorin at rehivetech.com
Sun Mar 20 10:41:10 CET 2016
On Sat, 19 Mar 2016 21:14:57 +0100
Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> 2016-03-19 20:58, Jan Viktorin:
> > The flag is used to enable memcpy optimizations in EAL. As it is not always
> > the performance benefit, the flag allows to disable it.
>
> Ideally the default should be to choose the best optimization.
> If it is not possible, it would help to have some comments explaining
> how to choose wether enabling NEON memcpy or not.
Ok, we can rename the option to CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY,
delete it from the defconfig and change the test in rte_memcpy_32.h to
#ifndef CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY
Alternatively, to have a positive test like
#ifdef CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY
I can create a bigger change that moves the non-neon-memcpy up in the
file...
Should I resend the whole series as v3?
Regards
Jan
More information about the dev
mailing list