[dpdk-dev] [PATCH 1/6] bonding: make eth_dev_ops const

Stephen Hemminger stephen at networkplumber.org
Mon Mar 21 18:53:24 CET 2016


This structure has immutable function pointers.
Also fix indentation.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>

---
 drivers/net/bonding/rte_eth_bond_pmd.c     | 38 +++++++++++++++---------------
 drivers/net/bonding/rte_eth_bond_private.h |  2 +-
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 011150a..8961a67 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2142,25 +2142,25 @@ bond_ethdev_rss_hash_conf_get(struct rte_eth_dev *dev,
 	return 0;
 }
 
-struct eth_dev_ops default_dev_ops = {
-		.dev_start            = bond_ethdev_start,
-		.dev_stop             = bond_ethdev_stop,
-		.dev_close            = bond_ethdev_close,
-		.dev_configure        = bond_ethdev_configure,
-		.dev_infos_get        = bond_ethdev_info,
-		.rx_queue_setup       = bond_ethdev_rx_queue_setup,
-		.tx_queue_setup       = bond_ethdev_tx_queue_setup,
-		.rx_queue_release     = bond_ethdev_rx_queue_release,
-		.tx_queue_release     = bond_ethdev_tx_queue_release,
-		.link_update          = bond_ethdev_link_update,
-		.stats_get            = bond_ethdev_stats_get,
-		.stats_reset          = bond_ethdev_stats_reset,
-		.promiscuous_enable   = bond_ethdev_promiscuous_enable,
-		.promiscuous_disable  = bond_ethdev_promiscuous_disable,
-		.reta_update          = bond_ethdev_rss_reta_update,
-		.reta_query           = bond_ethdev_rss_reta_query,
-		.rss_hash_update      = bond_ethdev_rss_hash_update,
-		.rss_hash_conf_get    = bond_ethdev_rss_hash_conf_get
+const struct eth_dev_ops default_dev_ops = {
+	.dev_start            = bond_ethdev_start,
+	.dev_stop             = bond_ethdev_stop,
+	.dev_close            = bond_ethdev_close,
+	.dev_configure        = bond_ethdev_configure,
+	.dev_infos_get        = bond_ethdev_info,
+	.rx_queue_setup       = bond_ethdev_rx_queue_setup,
+	.tx_queue_setup       = bond_ethdev_tx_queue_setup,
+	.rx_queue_release     = bond_ethdev_rx_queue_release,
+	.tx_queue_release     = bond_ethdev_tx_queue_release,
+	.link_update          = bond_ethdev_link_update,
+	.stats_get            = bond_ethdev_stats_get,
+	.stats_reset          = bond_ethdev_stats_reset,
+	.promiscuous_enable   = bond_ethdev_promiscuous_enable,
+	.promiscuous_disable  = bond_ethdev_promiscuous_disable,
+	.reta_update          = bond_ethdev_rss_reta_update,
+	.reta_query           = bond_ethdev_rss_reta_query,
+	.rss_hash_update      = bond_ethdev_rss_hash_update,
+	.rss_hash_conf_get    = bond_ethdev_rss_hash_conf_get
 };
 
 static int
diff --git a/drivers/net/bonding/rte_eth_bond_private.h b/drivers/net/bonding/rte_eth_bond_private.h
index 6c47a29..8312397 100644
--- a/drivers/net/bonding/rte_eth_bond_private.h
+++ b/drivers/net/bonding/rte_eth_bond_private.h
@@ -171,7 +171,7 @@ struct bond_dev_private {
 	uint8_t slave_update_idx;
 };
 
-extern struct eth_dev_ops default_dev_ops;
+extern const struct eth_dev_ops default_dev_ops;
 
 int
 check_for_bonded_ethdev(const struct rte_eth_dev *eth_dev);
-- 
2.1.4



More information about the dev mailing list