[dpdk-dev] [PATCH v3 05/10] qede: Add core driver

Bruce Richardson bruce.richardson at intel.com
Tue Mar 22 12:03:43 CET 2016


On Tue, Mar 22, 2016 at 10:55:54AM +0000, Bruce Richardson wrote:
> On Fri, Mar 18, 2016 at 05:53:20PM -0700, Rasesh Mody wrote:
> > Signed-off-by: Harish Patil <harish.patil at qlogic.com>
> > Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
> > Signed-off-by: Sony Chacko <sony.chacko at qlogic.com>
> > ---
> >  drivers/net/qede/Makefile                 |   90 +++
> >  drivers/net/qede/qede_eth_if.h            |  176 +++++
> >  drivers/net/qede/qede_ethdev.c            |  957 +++++++++++++++++++++++
> >  drivers/net/qede/qede_ethdev.h            |  156 ++++
> >  drivers/net/qede/qede_if.h                |  155 ++++
> >  drivers/net/qede/qede_logs.h              |   93 +++
> >  drivers/net/qede/qede_main.c              |  548 ++++++++++++++
> >  drivers/net/qede/qede_rxtx.c              | 1172 +++++++++++++++++++++++++++++
> >  drivers/net/qede/qede_rxtx.h              |  187 +++++
> >  drivers/net/qede/rte_pmd_qede_version.map |    4 +
> >  10 files changed, 3538 insertions(+)
> >  create mode 100644 drivers/net/qede/Makefile
> >  create mode 100644 drivers/net/qede/qede_eth_if.h
> >  create mode 100644 drivers/net/qede/qede_ethdev.c
> >  create mode 100644 drivers/net/qede/qede_ethdev.h
> >  create mode 100644 drivers/net/qede/qede_if.h
> >  create mode 100644 drivers/net/qede/qede_logs.h
> >  create mode 100644 drivers/net/qede/qede_main.c
> >  create mode 100644 drivers/net/qede/qede_rxtx.c
> >  create mode 100644 drivers/net/qede/qede_rxtx.h
> >  create mode 100644 drivers/net/qede/rte_pmd_qede_version.map
> > 
> Checkpatch is reporting a lot of issues with this patch. Can you please look to
> reduce the number of hits in it. Perhaps you could use the "checkpatches.sh"
> script in the dpdk repo to check all patches in this set.
> 
> Regards,
> /Bruce

Also, can the commit be given a fuller description in the commit message
describing what is included in this patch, and also what is omitted from it i.e.
what's going to be added in later patches.

/Bruce


More information about the dev mailing list