[dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes

Bruce Richardson bruce.richardson at intel.com
Tue Mar 22 15:29:58 CET 2016


On Thu, Mar 10, 2016 at 05:47:56PM -0800, Rasesh Mody wrote:
> Signed-off-by: Harish Patil <harish.patil at qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
> ---
>  drivers/net/bnx2x/bnx2x.c        |  207 +++++++++++++++++---------------------
>  drivers/net/bnx2x/bnx2x.h        |    4 +-
>  drivers/net/bnx2x/bnx2x_ethdev.c |   53 ++++++++++
>  drivers/net/bnx2x/bnx2x_rxtx.c   |   47 +++++----
>  4 files changed, 173 insertions(+), 138 deletions(-)
> 
This patch needs a commit message with a description of changes and how they 
help with performance.

If there are multiple changes being made to improve the performance, or add in
extra TX features, they would be better split into separate patches, with one
unique change per patch. If any of the changes are bug-fixes as opposed to
performance improvements (since the word "fixes" appears in the title here), they
should each be in a separate patch, with a message describing the fix and
including a "fixes" line in the message as described here:
http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body

Thanks,
/Bruce


More information about the dev mailing list