[dpdk-dev] [PATCH] vhost PMD: Fix wrong handling of maximum value of rx/tx queues

Bruce Richardson bruce.richardson at intel.com
Wed Mar 23 18:45:22 CET 2016


On Tue, Mar 22, 2016 at 05:17:42PM +0000, Loftus, Ciara wrote:
> > 
> > Currently, the maximum value of rx/tx queueus are kept by EAL. But,
> > the value are used like below different meanings in vhost PMD.
> >  - The maximum value of current enabled queues.
> >  - The maximum value of current supported queues.
> > 
> > This wrong double meaning will cause an issue like below steps.
> > 
> > * Invoke application with below option.
> >   --vdev 'eth_vhost0,iface=<socket path>,queues=4'
> > * Configure queues like below.
> >   rte_eth_dev_configure(portid, 2, 2, ...);
> > * Configure queues again like below.
> >   rte_eth_dev_configure(portid, 4, 4, ...);
> > 
> > The second rte_eth_dev_configure() will be failed because both
> > the maximum value of current enabled queues and supported queues
> > will be '2' after calling first rte_eth_dev_configure().
> > 
> > To fix the issue, the patch prepare one more variable to keep the
> > number of maximum supported queues in vhost PMD.
> > 
> > Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp>
> > ---
<snip> 
> Acked-by: Ciara Loftus <ciara.loftus at intel.com>
> 
Applied to dpdk-next-net/rel_16_04

/Bruce


More information about the dev mailing list