[dpdk-dev] Bug in i40e PMD for flexible payload

Bruce Richardson bruce.richardson at intel.com
Thu Mar 24 13:04:19 CET 2016


On Wed, Mar 23, 2016 at 01:44:46PM -0500, Michael Habibi wrote:
> We are using the i40 implementation to configure flow director with
> flexible payload rules. When setting up rules, it allows you to set a value
> to 63 to disable the rule (NONUSE_FLX_PIT_DEST_OFF). However, the macro in
> question is always adding an offset value 50
> (I40E_FLX_OFFSET_IN_FIELD_VECTOR). This doesn't work when you use it in
> conjunction with NONUSE_FLX_PIT_DEST_OFF to disable it, because instead of
> taking 63 as is, it does 63 + 50 and breaks the functionality.
> 
> We used the following fix and it appears to work. Just sharing with the
> DPDK team in case they want to bring it in.
>
Thanks for this. Can you perhaps resubmit this fix in the form of an official
patch to DPDK, including a proper sign-off on it. The details for contributing
patches to DPDK is documented here: 
http://dpdk.org/doc/guides/contributing/patches.html

Without a signoff, we can't take in your code and use it.

Regards,
/Bruce


More information about the dev mailing list