[dpdk-dev] [PATCH] ixgbe: fix vector RX can't always set packet_type properly

Bruce Richardson bruce.richardson at intel.com
Thu Mar 24 13:25:45 CET 2016


On Wed, Mar 23, 2016 at 10:54:23AM +0800, Liang, Cunming wrote:
> Hi,
> 
> On 3/22/2016 10:30 PM, Konstantin Ananyev wrote:
> >Fixes: 39625417585 ("mbuf: redefine packet type")
> >
> >Current vector RX can't always set packet_type properly.
> >To be more specific:
> >a) it never sets RTE_PTYPE_L2_ETHER
> >b) it doesn't handle tunnel ipv4/ipv6 case correctly.
> >c) it doesn't check is IXGBE_RXDADV_PKTTYPE_ETQF set or not.
> >While a) is pretty easy to fix, b) and c) are not that straightforward
> >in terms of SIMD ops (specially b).
> >So far I wasn't able to make vRX support packet_type properly without
> >noticeable performance loss.
> >So for now, just remove that functionality at all from vector RX and
> >update dev_supported_ptypes_get().
> >
> >Signed-off-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
> >---
> >  drivers/net/ixgbe/ixgbe_ethdev.c   |  4 +---
> >  drivers/net/ixgbe/ixgbe_rxtx_vec.c | 34 +++++++++++-----------------------
> >  2 files changed, 12 insertions(+), 26 deletions(-)
> >
> >
> Acked-by: Liang Cunming <cunming.liang at intel.com>

Applied to dpdk-next-net/rel_16_04

/Bruce


More information about the dev mailing list