[dpdk-dev] [PATCH v4 1/3] ethdev: refine API to query supported packet types

Bruce Richardson bruce.richardson at intel.com
Fri Mar 25 11:13:26 CET 2016


On Fri, Mar 25, 2016 at 08:47:45AM +0800, Jianfeng Tan wrote:
> Return 0 instead of -ENOTSUP for those which do not fill any packet types,
> with some note and doc updated.
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan at intel.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>

Hi Jianfeng,

I think this is a good change to the API, as it should simplify app code - as
any driver which doesn't tell us what ptypes it supports should be counted as
not supporting any. It also eliminates the need for the vdevs to see about
exporting this function to say they don't support any types.

However, two comments:
1. I think the commit message for this change should include information as to
why we want to tweak the API of this new function i.e. put in the above reasons
plus any others.
2. Please separate out the doc change from the API change as they are unrelated.

Regards,
/Bruce



More information about the dev mailing list