Making code run with picky compilers is good, as long as it doesn't break other (more modern) compilers. > + new_tbl8_entry.next_hop=next_hop; Please run your patches through checkpatch, it will warn about missing whitespace like this.