[dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get

Rasesh Mody rasesh.mody at qlogic.com
Sat May 7 02:14:23 CEST 2016


> From: Bruce Richardson [mailto:bruce.richardson at intel.com]
> Sent: Friday, May 06, 2016 7:47 AM
> 
> On Tue, May 03, 2016 at 10:38:21PM -0700, Rasesh Mody wrote:
> > Enhance the stats_get() routine to display drop counters under imissed
> > counter.
> > Added extended stats get support to provide additional info.
> > Encorporated review comment to rename some of the stats.
> >
> > Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
> > Signed-off-by: Harish Patil <harish.patil at qlogic.com>
> 
> Again this seems to me like it should be two patches rather than one. A first
> patch as a fix for the drop counters and then a second patch to add the xstats
> functionality.
>
> Regards,
> /Bruce
We shall split this patch into an enhancement and a bug fix.
 
Thanks!
Rasesh


More information about the dev mailing list