[dpdk-dev] [PATCH v3] eal: make hugetlb initialization more robust
Tan, Jianfeng
jianfeng.tan at intel.com
Tue May 10 11:11:32 CEST 2016
Hi Sergio,
> -----Original Message-----
> From: Gonzalez Monroy, Sergio
> Sent: Tuesday, May 10, 2016 4:55 PM
> To: Tan, Jianfeng; dev at dpdk.org
> Cc: david.marchand at 6wind.com; nhorman at tuxdriver.com
> Subject: Re: [PATCH v3] eal: make hugetlb initialization more robust
>
>
> Hi Jianfeng,
>
> On 09/05/2016 11:48, Jianfeng Tan wrote:
>
> > /* find physical addresses and sockets for each hugepage */
> > @@ -1172,8 +1255,9 @@ rte_eal_hugepage_init(void)
> > hp_offset += new_pages_count[i];
> > #else
> > /* remap all hugepages */
> > - if (map_all_hugepages(&tmp_hp[hp_offset], hpi, 0) < 0){
> > - RTE_LOG(DEBUG, EAL, "Failed to remap %u MB
> pages\n",
> > + if ((uint32_t)map_all_hugepages(&tmp_hp[hp_offset], hpi,
> 0) !=
> > + hpi->num_pages[0]) {
>
> It probably makes more sense to have map_all_hugepages return uint32_t
> instead.
Yes, I agree. I was wrongly expecting there's a freebsd version map_all_hugepages with the same function type.
I'll fix this in next version.
Thanks,
Jianfeng
>
> Sergio
More information about the dev
mailing list