[dpdk-dev] [PATCH v2 06/11] app/test: use linked list to store PCI drivers

Thomas Monjalon thomas.monjalon at 6wind.com
Thu May 12 23:44:50 CEST 2016


2016-05-12 23:00, Jan Viktorin:
> On Thu, 12 May 2016 18:08:16 +0200
> Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> 
> > 2016-05-12 17:53, Jan Viktorin:
> > > On Thu, 12 May 2016 17:31:28 +0200
> > > Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> > >   
> > > > 2016-05-10 20:13, Jan Viktorin:  
> > > > > The test unregisters all real drivers before starting into an array. This
> > > > > inflexiable as we can use a linked list for this purpose.    
> > > > 
> > > > I don't understand this. Maybe some words are missing.  
> > > 
> > > Better?
> > > 
> > > The test unregisters all real drivers before starting (stored into an array).
> > > This is inflexiable (due to its fixed size) and we can use a linked list for
> > > this purpose.    
> > 
> > Better with a past tense? "The test was unregistering..."
> 
> No. This patch does not change the semantics (well, it does, because
> the list of drivers become global but that's all). The test still
> unregisters the drivers. That is the important fact to consider.
> 
> Perhaps:
> 
> The test unregisters all drivers before start. The drivers were stored
> into a fixed-sized array. This is inflexible. This patch change this to
> utilize a linked list for the same purpose.

Yes better. Thanks


More information about the dev mailing list