[dpdk-dev] [PATCH v2 08/11] app/test: convert current pci_test into a single test case

Jan Viktorin viktorin at rehivetech.com
Fri May 13 17:19:42 CEST 2016


On Thu, 12 May 2016 17:34:13 +0200
Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:

> 2016-05-10 20:13, Jan Viktorin:
> > The current test_pci is just a single test case that tests the blacklisting
> > of devices. Rename it to test_pci_blacklist and call it from the test_pci.  
> 
> The functions are also moved. It is confusing.
> Maybe this patch can be squashed with the previous one.
> 

Well, I wanted to separate the functional changes from cosmetic ones.
The goal here is to extract the setup and cleanup phases from the orignal
test. Would be better to just change the description?

---

app/test: extract setup and cleanup phase from pci_test

The original test_pci contains the setup and cleanup phase in its body.
By extracting this code out, we can take advantage of this code for other
(future) tests as well.

The test_pci is renamed to test_pci_blacklist - it's only a single test
case (others will follow) now.

---

Probably, it can be splitted (instead of squashed with a previous one) to
"extract setup and cleanup" and "rename to test_pci_blacklist".

Jan

-- 
   Jan Viktorin                  E-mail: Viktorin at RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic


More information about the dev mailing list