[dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer keys

Tahhan, Maryam maryam.tahhan at intel.com
Wed May 18 10:31:32 CEST 2016


<snip>
>  					     uint8_t stat_idx,
> @@ -1427,6 +1447,10 @@ struct eth_dev_ops {
>  	eth_stats_reset_t          stats_reset;   /**< Reset generic device
> statistics. */
>  	eth_xstats_get_t           xstats_get;    /**< Get extended device
> statistics. */
>  	eth_xstats_reset_t         xstats_reset;  /**< Reset extended
> device statistics. */
> +	eth_xstats_names_t         xstats_names;
> +	/**< Get names of extended statistics. */
> +	eth_xstats_count_t         xstats_count;
> +	/**< Get number of extended statistics. */

Hi Remy
While reviewing the second patch in this patchset I noticed you aren't actually using 
eth_xstats_count_t   xstats_count in the eth_dev_ops to retrieve the count in the driver. 
Do you still need xstats_count?

BR
Maryam
<snip>


More information about the dev mailing list