[dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer keys

Remy Horton remy.horton at intel.com
Wed May 18 10:45:36 CEST 2016


On 18/05/2016 09:31, Tahhan, Maryam wrote:
[..]
>> +	eth_xstats_count_t         xstats_count;
>> +	/**< Get number of extended statistics. */
>
> Hi Remy
> While reviewing the second patch in this patchset I noticed you aren't actually using
> eth_xstats_count_t   xstats_count in the eth_dev_ops to retrieve the count in the driver.
> Do you still need xstats_count?

Well spotted - bit of dead code that slipped through the net when I 
decided to use the existing convention for the driver-side interface.

Currently working on a v3 that will convert all the drivers, so will fix 
in that patchset.

..Remy


More information about the dev mailing list