[dpdk-dev] [PATCH 07/20] thunderx/nicvf: add rx_queue_setup/release support

[Pattan, Reshma]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob
> Sent: Saturday, May 7, 2016 4:16 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Richardson, Bruce
> <bruce.richardson at intel.com>; Jerin Jacob
> <jerin.jacob at caviumnetworks.com>; Maciej Czekaj
> <maciej.czekaj at caviumnetworks.com>; Kamil Rytarowski
> <Kamil.Rytarowski at caviumnetworks.com>; Zyta Szpak
> <zyta.szpak at semihalf.com>; Slawomir Rosek <slawomir.rosek at semihalf.com>;
> Radoslaw Biernacki <rad at semihalf.com>
> Subject: [dpdk-dev] [PATCH 07/20] thunderx/nicvf: add rx_queue_setup/release
> support
> 
> diff --git a/drivers/net/thunderx/nicvf_ethdev.c
> b/drivers/net/thunderx/nicvf_ethdev.c
> index 1269672..3b94168 100644
> --- a/drivers/net/thunderx/nicvf_ethdev.c
> +++ b/drivers/net/thunderx/nicvf_ethdev.c
> 
> +static int
> +nicvf_qset_cq_alloc(struct nicvf *nic, struct nicvf_rxq *rxq, uint16_t qidx,
> +		    uint32_t desc_cnt)
> +{
> +	const struct rte_memzone *rz;
> +	uint32_t ring_size = desc_cnt * sizeof(union cq_entry_t);
> +
> +	rz = rte_eth_dma_zone_reserve(nic->eth_dev, "cq_ring", qidx, ring_size,
> +				   NICVF_CQ_BASE_ALIGN_BYTES, nic->node);
> +	if (rz == NULL) {
> +		PMD_INIT_LOG(ERR, "Failed allocate mem for cq hw ring");

Typo "Failed to"?

> +static int
> +nicvf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t qidx,
> +			 uint16_t nb_desc, unsigned int socket_id,
> +			 const struct rte_eth_rxconf *rx_conf,
> +			 struct rte_mempool *mp)
> +{
> +	uint16_t rx_free_thresh;
> +	struct nicvf_rxq *rxq;
> +	struct nicvf *nic = nicvf_pmd_priv(dev);
> +
> +	PMD_INIT_FUNC_TRACE();
> +
> +	/* Socked id check */

Typo  "Socket"?

Thanks,
Reshma