[dpdk-dev] [PATCH 5/6] testpmd: show topology at forwarding start
Wang, Zhihong
zhihong.wang at intel.com
Thu May 26 04:56:39 CEST 2016
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, May 25, 2016 5:45 PM
> To: Wang, Zhihong <zhihong.wang at intel.com>
> Cc: dev at dpdk.org; Ananyev, Konstantin <konstantin.ananyev at intel.com>;
> Richardson, Bruce <bruce.richardson at intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch at intel.com>
> Subject: Re: [PATCH 5/6] testpmd: show topology at forwarding start
>
> 2016-05-05 18:47, Zhihong Wang:
> > This patch show topology at forwarding start.
> >
> > "show config fwd" also does this, but showing it directly can reduce the
> > possibility of misconfiguration.
> [...]
> > - fwd_config_setup();
> > + fwd_config_display();
> > rxtx_config_display();
>
> Having _display() calling _setup() is really strange.
> Maybe it is worth to be fixed in this patch.
It looks strange to me too. Will look for a fix.
More information about the dev
mailing list