[dpdk-dev] [PATCH v2 02/40] bnxt: add HWRM init code

[Bruce Richardson]

On Wed, May 25, 2016 at 04:35:27PM -0700, Stephen Hurd wrote:
> On Wed, May 25, 2016 at 8:05 AM, Bruce Richardson <
> bruce.richardson at intel.com> wrote:
> 
> >
> > Checkpatch also highlights a few minor issues that might be worth
> > addressing.
> >
> >   CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
> >   #137: FILE: drivers/net/bnxt/bnxt.h:94:
> >   +#define BNXT_FLAG_VF           (1<<1)
> >                                   ^
> >
> >   WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
> >   #259: FILE: drivers/net/bnxt/bnxt_ethdev.c:143:
> >   +       /*
> >   +       eth_dev->rx_pkt_burst = &bnxt_recv_pkts;
> >
> >   WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> >   #366: FILE: drivers/net/bnxt/bnxt_hwrm.c:56:
> >   +       unsigned i;
> >
> >
> What version of checkpatch.pl should we be using?  These were not found by
> the one I had.
> 
Not to worry, a few checkpatch issues are not that big a problem, I can fix them
on apply if necessary.

I used the latest checkpatch version on linus' tree, since I just did a clone
of that before starting looking at your set. Since I don't pull down the patches
as patch files, but use pwclient git-am to apply them, I don't use the checkpatches.sh
script. The actual command/script I use is:

#! /bin/sh

IGNORE_FLAGS="LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
VOLATILE,PREFER_PACKED,PREFER_ALIGNED,\
PREFER_PRINTF,PREFER_KERNEL_TYPES,\
PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
COMPARISON_TO_NULL,SPLIT_STRING,BIT_MACRO,LINE_SPACING"

git show --pretty=email | /usr/src/linux/scripts/checkpatch.pl --max-line-length=90 --show-types --ignore=$IGNORE_FLAGS -

The ignore flags should be pretty much the same as in checkpatches.pl, but there
may be a couple of differences, since I haven't synced them up in some time. I
will attempt do so in the near future, to avoid confusion here.

/Bruce