[dpdk-dev] [PATCH v2 01/40] bnxt: new driver for Broadcom NetXtreme-C devices

[Bruce Richardson]

On Wed, May 25, 2016 at 01:59:00PM -0700, Stephen Hurd wrote:
> Bruce, is it better at this point to modify the existing patch that adds
> bnxt.rst or to create a follow-on patch?
> 

It's better to modify existing patch to add it. 

However, hold off on doing new versions of the patchset until I've finished
doing a first initial scan of them as-is [you'll see from my emails I'm less
than half way in at this point! :-)].

I'd also like to see if some others can help out with reviewing this patchset.
It is a lot of patches, but since they are logically broken up by functionality,
each one is of more manageable size.

Any volunteers?

/Bruce

> On Wed, May 25, 2016 at 8:02 AM, Bruce Richardson <
> bruce.richardson at intel.com> wrote:
> 
> > On Fri, May 13, 2016 at 03:45:50PM -0700, Stephen Hurd wrote:
> > > Initial skeleton simply fails init.
> > > Add nic guide and tie into build system.
> > >
> > > Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> > > ---
> > >  MAINTAINERS                                     |   5 ++
> > >  config/common_base                              |   5 ++
> > >  doc/guides/nics/bnxt.rst                        |  49 +++++++++++
> > >  drivers/net/Makefile                            |   1 +
> > >  drivers/net/bnxt/Makefile                       |  63 ++++++++++++++
> > >  drivers/net/bnxt/bnxt_ethdev.c                  | 104
> > ++++++++++++++++++++++++
> > >  drivers/net/bnxt/rte_pmd_bnxt_version.map       |   4 +
> > >  lib/librte_eal/common/include/rte_pci_dev_ids.h |  40 +++++++--
> > >  mk/rte.app.mk                                   |   1 +
> > >  9 files changed, 267 insertions(+), 5 deletions(-)
> > >  create mode 100644 doc/guides/nics/bnxt.rst
> > >  create mode 100644 drivers/net/bnxt/Makefile
> > >  create mode 100644 drivers/net/bnxt/bnxt_ethdev.c
> > >  create mode 100644 drivers/net/bnxt/rte_pmd_bnxt_version.map
> > >
> > Great to see this patchset split up finer grained, and it getting compiled
> > from
> > the start. Thanks for the work.
> >
> > One error that gets flagged by the automated patch checks here is that,
> > although
> > you add in a new doc for the new driver in this patch, that document is not
> > included in the overall NIC guides document.
> >
> >     /home/bruce/next-net/dpdk-next-net/doc/guides/nics/bnxt.rst:: WARNING:
> > document isn't included in any toctree
> >
> > Regards,
> > /Bruce
> >
> >
> 
> 
> -- 
> Stephen Hurd
> Principal Engineer - Software Development
> Broadcom Corporation
> 949-926-8039
> stephen.hurd at broadcom.com