[dpdk-dev] [PATCH v2 14/40] bnxt: initial Rx ring code

[Bruce Richardson]

On Fri, May 13, 2016 at 03:46:03PM -0700, Stephen Hurd wrote:
> Initial implementation of rx_pkt_burst
> Add code to allocate rings to bnxt_ring.c
> 
> Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde at broadcom.com>
> ---
>  drivers/net/bnxt/Makefile              |   1 +
>  drivers/net/bnxt/bnxt_ethdev.c         |   3 +-
>  drivers/net/bnxt/bnxt_ring.c           |  20 +-
>  drivers/net/bnxt/bnxt_rxq.c            |  34 ++-
>  drivers/net/bnxt/bnxt_rxr.c            | 338 +++++++++++++++++++++++
>  drivers/net/bnxt/bnxt_rxr.h            |  62 +++++
>  drivers/net/bnxt/hsi_struct_def_dpdk.h | 474 +++++++++++++++++++++++++++++++++
>  7 files changed, 915 insertions(+), 17 deletions(-)
>  create mode 100644 drivers/net/bnxt/bnxt_rxr.c
>  create mode 100644 drivers/net/bnxt/bnxt_rxr.h
> 
<snip>
> + */
> +
> +static inline struct rte_mbuf *__bnxt_alloc_rx_data(struct rte_mempool *mb)
> +{
> +	struct rte_mbuf *data;
> +
> +	data = __rte_mbuf_raw_alloc(mb);

This function is now deprecated and the version without "__" prefix should
now be used instead. "rte_mbuf_raw_alloc()"

> +	__rte_mbuf_sanity_check(data, 0);

raw_mbuf_raw_alloc already includes a call to sanity_check, so this can be removed.
Perhaps the whole function __bnxt_alloc_rx_data() can be removed as it just
seems to be duplicating rte_mbuf_raw_alloc().

Regards,
/Bruce