[dpdk-dev] [PATCH] kni: fix use of undefined comma variable in makefile
Ferruh Yigit
ferruh.yigit at intel.com
Mon May 30 17:49:55 CEST 2016
On 5/30/2016 12:56 PM, Olivier Matz wrote:
> The $(comma) variable is not defined in this Makefile, nor in
> any included Makefile. Seen while doing a "make clean" on ubuntu:
>
> $ make clean
> == Clean lib
> == Clean lib/librte_compat
> == Clean lib/librte_eal
> == Clean lib/librte_eal/common
> == Clean lib/librte_eal/linuxapp
> == Clean lib/librte_eal/linuxapp/eal
> == Clean lib/librte_eal/linuxapp/igb_uio
> == Clean lib/librte_eal/linuxapp/kni
> tr: missing operand after ‘.-’
> Two strings must be given when translating.
> Try 'tr --help' for more information.
I don't observe this error on Ubuntu.
Also did a quick check and $(comma) seems defined, but not sure exactly
where. What I test:
$ lsb_release -si
Ubuntu
$ git diff
diff --git a/lib/librte_eal/linuxapp/kni/Makefile
b/lib/librte_eal/linuxapp/kni/Makefile
index ac99d3f..dcad241 100644
--- a/lib/librte_eal/linuxapp/kni/Makefile
+++ b/lib/librte_eal/linuxapp/kni/Makefile
@@ -90,4 +90,7 @@ SRCS-y += kni_net.c
SRCS-y += kni_ethtool.c
SRCS-$(CONFIG_RTE_KNI_VHOST) += kni_vhost.c
+test_comma:
+ @echo "= comma: $(comma) ="
+
$ make -C lib/librte_eal/linuxapp/kni test_comma
make: Entering directory '.../dpdk/lib/librte_eal/linuxapp/kni'
= comma: , =
make: Leaving directory '.../dpdk/lib/librte_eal/linuxapp/kni'
More information about the dev
mailing list